Add SAML Assertion Encryption and Metadata Encryption Support#956
Closed
nevzatcirak wants to merge 3 commits intoory:mainfrom
Closed
Add SAML Assertion Encryption and Metadata Encryption Support#956nevzatcirak wants to merge 3 commits intoory:mainfrom
nevzatcirak wants to merge 3 commits intoory:mainfrom
Conversation
|
Nevzat ÇIRAK seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to encrypt SAML Assertions and sign the root Response element, enhancing security compliance with SAML 2.0 standards.
The implementation follows a hybrid encryption approach where the assertion data is encrypted using a symmetric key (e.g., AES-256), which is then encrypted using the Service Provider's public key (RSA-OAEP).
Key Changes:
• Assertion Encryption: Implemented logic to wrap assertions in saml:EncryptedAssertion elements using the xml-encryption library.
• Response Signing: Added support for signing the outer samlp:Response element in addition to the assertion signature.
• Metadata Update: Updated createIdPMetadataXML to advertise encryption support and algorithms via KeyDescriptor (use="encryption").
• Refactoring: Standardized ID generation and improved the sign utility to better handle KeyInfo placement.
• Tests: Added unit tests covering encryption flows, metadata generation, and response structure validation.